-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-2005919: update tests to fix disabled sql simplifier workflow #3195
Merged
sfc-gh-lmukhopadhyay
merged 5 commits into
main
from
lmukhopadhyay-SNOW-2005919-sql-simplifier-disabled-errors
Mar 26, 2025
Merged
SNOW-2005919: update tests to fix disabled sql simplifier workflow #3195
sfc-gh-lmukhopadhyay
merged 5 commits into
main
from
lmukhopadhyay-SNOW-2005919-sql-simplifier-disabled-errors
Mar 26, 2025
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Loading status checks…
…sabled-errors
Loading status checks…
…sabled-errors
sfc-gh-jjiao
approved these changes
Mar 26, 2025
sfc-gh-nkumar
approved these changes
Mar 26, 2025
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
sfc-gh-helmeleegy
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Labanya. Left one suggestion, but otherwise it looks good.
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
snowpark-pandas
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2005919
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Update tests
test_dataframe_groupby_transform_conflicting_labels
andtest_to_snowpark_pandas_duplicated_columns_raises
to fix disabled sql simplifier workflow.Passing workflow run: https://github.com/snowflakedb/snowpark-python/actions/runs/14072875832