Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-2005919: update tests to fix disabled sql simplifier workflow #3195

Conversation

sfc-gh-lmukhopadhyay
Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay commented Mar 26, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2005919

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

Update tests test_dataframe_groupby_transform_conflicting_labels and test_to_snowpark_pandas_duplicated_columns_raises to fix disabled sql simplifier workflow.
Passing workflow run: https://github.com/snowflakedb/snowpark-python/actions/runs/14072875832

Sorry, something went wrong.

Signed-off-by: Labanya Mukhopadhyay <[email protected]>
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Mar 26, 2025
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay requested a review from a team as a code owner March 26, 2025 15:01
@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Signed-off-by: Labanya Mukhopadhyay <[email protected]>
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Labanya. Left one suggestion, but otherwise it looks good.

Signed-off-by: Labanya Mukhopadhyay <[email protected]>
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay merged commit 8e44d9b into main Mar 26, 2025
37 checks passed
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay deleted the lmukhopadhyay-SNOW-2005919-sql-simplifier-disabled-errors branch March 26, 2025 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants