Skip to content

SNOW-2455523: Add support for scalar string and binary functions - part 3 #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-aherreraaguilar merged 20 commits into from
Nov 4, 2025
Merged

SNOW-2455523: Add support for scalar string and binary functions - part 3 #3947

sfc-gh-aherreraaguilar merged 20 commits into from
Nov 4, 2025

Conversation

@sfc-gh-aherreraaguilar
Copy link
Collaborator

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar commented Oct 23, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2455523

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

Add support for scalar string and binary functions:
strtok
try_base64_decode_binary
try_base64_decode_string
try_hex_decode_binary
try_hex_decode_string
unicode
uuid_string

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar changed the title Add support for scalar string and binary functions - part 3 SNOW-2455523: Add support for scalar string and binary functions - part 3 Oct 23, 2025
graphite-app[bot]
graphite-app bot reviewed Oct 28, 2025
View reviewed changes
sfc-gh-mvegaalvarez
sfc-gh-mvegaalvarez approved these changes Oct 28, 2025
View reviewed changes
Copy link

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just fix graphite comment for missing return at else

graphite-app[bot]
graphite-app bot reviewed Oct 30, 2025
View reviewed changes
sfc-gh-aling
sfc-gh-aling approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like PR https://github.com/snowflakedb/snowpark-python/pull/3946/files also duplicated the code change for those functions

@sfc-gh-aling sfc-gh-aling mentioned this pull request Oct 31, 2025
Closed
9 tasks
@sfc-gh-aherreraaguilar
Copy link
Collaborator Author

sfc-gh-aherreraaguilar commented Oct 31, 2025 •
edited
Loading

@sfc-gh-aling I removed the duplicated functions from the other PR

@sfc-gh-aherreraaguilar
Merge branch 'main' into feature/aherrera/SNOW-2455523
9c0e5f2 
# Conflicts:
#	CHANGELOG.md
#	src/snowflake/snowpark/_functions/scalar_functions.py
graphite-app[bot]
graphite-app bot reviewed Nov 1, 2025
View reviewed changes
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar merged commit 4727d26 into main Nov 4, 2025
29 checks passed
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar deleted the feature/aherrera/SNOW-2455523 branch November 4, 2025 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-aherreraaguilar @sfc-gh-aling @sfc-gh-mvegaalvarez