Skip to content

fix: export Event #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

spinx
Copy link

@spinx spinx commented Jun 8, 2023

This exports Event interface so it can be used when doing transformations

@dokmic
Copy link
Contributor

dokmic commented Jun 14, 2023

Hey, @spinx!

Thanks for contributing!

In your fix, you are adding another entrypoint to the bundler configuration, which is not precisely correct as there is a risk of exposing some encapsulated entries from that file. That also makes the project structure more brittle if this file gets renamed.

The correct way of doing that would be to reexport the interface at the bottom of index.ts:

export type { Event } from './event';

@spinx
Copy link
Author

spinx commented Jun 19, 2023

HI @dokmic, fixed to the correct way now.

Co-authored-by: Michael Dokolin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants