-
Notifications
You must be signed in to change notification settings - Fork 56
Failed events alerts DQD #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Failed events alerts DQD #1319
Conversation
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@patofp just few minor suggestions:
Maybe add a section for Slack in the Troubleshooting, perhaps link to any useful documentation they may have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a little overkill to mark the whole existing Failed events section as Legacy? Is the data quality dashboard still a thing?
I think it's confusing to have two sections named something about failed events within the Data quality section, can you combine them please
My two cents - could we rename "Legacy Failed events" to be "Failed Events" and then nest the new pages under an "Alerting" section within "Failed Events"? |
@jborlase-snowplow does this look better? |
LGTM! |
Added basic guide for new failed events.
Not sure if we should remove or mark as deprecated the old failed events alert.