Tidy up Signals tutorials #1328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscwilson
force-pushed
the
signals-basic-tutorials
branch
from
9a77f45 to
0313e4d
Compare
mscwilson
requested review from
Jack-Keene,
matus-tomlein,
agnessnowplow,
greg-el,
pif and
johnmicahreid
and removed request for
Jack-Keene and
matus-tomlein
johnmicahreid
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Overall the changes look good to me - thanks for a massive lift here @mscwilson !
|
|
||
| To retrieve the calculated attributes from the Profiles Store, Signals provides a configuration wrapper called a service. It allows you to retrieve attributes in bulk, from multiple views. | ||
|
|
||
| Using services is optional: you could also reference the views directly in your application code. |
There was a problem hiding this comment.
I think we need to push Services more aggressively, and explain that they define the data contract for what the application expects. So I would not call them optional - I would say recommended.
| | 7 | `4da52032-f6d1-41b4-9cf2-b40e164cbe6e` | 1 | "Chrome" | None | | ||
| | 8 | `2ee80a4a-86dd-4a24-b697-0709b29ed079` | 0 | "Safari" | None | | ||
|
|
||
| The test method returns the most recent 10 rows. The first column shows the entity values, in this case for the session entity `domain_sessionid`. |
There was a problem hiding this comment.
I don't think it's quite right that it retrieves the most recent 10 rows - I remember it being 10 random users / entities calculated from events in the last hour. @matus-tomlein can you confirm?
|
|
||
| ## Next steps | ||
|
|
||
| Learn more about the Signals possibilities in our other Signals tutorials. |
There was a problem hiding this comment.
Can we link them here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardising and polishing the Signals tutorials