Skip to content

bugfix: Crash when invoke socket::close(). #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix: Crash when invoke socket::close(). #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/sio_socket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ namespace sio

std::mutex m_packet_mutex;

std::mutex m_client_mutex;

friend class socket;
};

Expand Down Expand Up @@ -281,6 +283,8 @@ namespace sio

void socket::impl::close()
{
std::lock_guard<std::mutex> guard(m_client_mutex);

NULL_GUARD(m_client);
if(m_connected)
{
Expand All @@ -294,6 +298,8 @@ namespace sio
boost::system::error_code ec;
m_connection_timer->expires_from_now(boost::posix_time::milliseconds(3000), ec);
m_connection_timer->async_wait(lib::bind(&socket::impl::on_close, this));
m_connection_timer->cancel();
m_connection_timer.reset();
}
}

Expand Down Expand Up @@ -328,13 +334,11 @@ namespace sio
{
NULL_GUARD(m_client);
sio::client_impl *client = m_client;

std::lock_guard<std::mutex> guard_client(m_client_mutex);

m_client = NULL;

if(m_connection_timer)
{
m_connection_timer->cancel();
m_connection_timer.reset();
}
m_connected = false;
{
std::lock_guard<std::mutex> guard(m_packet_mutex);
Expand Down