Update all values of a DNS record #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaka-ruto
force-pushed
the
update-dns
branch
from
2dd4099 to
08ac2a0
Compare
|
Apologies for being slow to get back to you. Do you mind rebasing on top of the latest Thanks. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
updatemethod for DNS records, which will update all the values of a DNS record, namely: thetype,name,contentandoptions,The current
update_contentmethod only updates the content of a DNS record, leaving behind the three other options.With this change, the current
update_contentcan be marked as deprecated as the newupdatemethod can take care of updating content only as well, in addition to all the other options.Types of Changes
Contribution