Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve docs #605

Merged
merged 4 commits into from
Sep 21, 2023
Merged

chore(docs): improve docs #605

merged 4 commits into from
Sep 21, 2023

Conversation

chicoxyzzy
Copy link
Member

No description provided.

@chicoxyzzy chicoxyzzy requested review from jwerle, heapwolf and bcomnes and removed request for jwerle and heapwolf September 21, 2023 14:56
@chicoxyzzy
Copy link
Member Author

@bcomnes what other modules from socket:test should I add?

Comment on lines +16 to +17
const SECOND = 1000
const defaultTimeout = 5 * SECOND
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's just keep dom-helpers out of the public docs for now.

@chicoxyzzy chicoxyzzy merged commit 9c88cb8 into master Sep 21, 2023
@chicoxyzzy chicoxyzzy deleted the more_docs branch September 21, 2023 20:32
@chicoxyzzy chicoxyzzy added the documentation Improvements or additions to documentation label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants