Refactor RadioDataWidget #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) RadioDataWidget is now renamed as OptionGroupWidget. 2) Both OptionGroupWidget and SelectableItemWidget are now in their own .h/.cpp files 3) The switch of behavior depending on the number of alternative is removed Because there is no reason justifying that a widget for a data field would totally change its rendering/behavior depending on the number of alternatives. If the Radio choices behavior is needed (which I doubt) it is easy to re-implement it on a per-component-data basis using BaseData::setWidget/getWidget. Signed-off-by: Damien Marchal <[email protected]>
hugtalbot
approved these changes
Aug 20, 2025
Contributor
Author
|
The CI error is related to the PR, I will investigate so I pass it back to WIP. |
Contributor
Author
|
@hugtalbot the compilation issue is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both SelectableItem and OptionGroup use kind of a a "dual" style widget because, depending on the number of items, it could either use radio checkboxes or a combobox.
This is questionable choices as:
Thus, I removed the radiobox option and clean a bit that part of the code:
Here is an example of how the UX for OptionGroup with less than 4 items (the three items):
Here is an example of the UX for an OptionGroup with more than 3 items (a ComboBox)):
NB: In case, a radio button choice selector is needed it is easy to re-implement it on a per-component basis using BaseData::setWidget/getWidget.