Skip to content

[Tools] Fix windows postinstall #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olivier-roussel wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −7
Open

[Tools] Fix windows postinstall #5879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60367c7
apply windows postinstall script also on non-release builds
olivier-roussel Jan 22, 2026
79e4d44
remove deprecated collections postinstall fixes
olivier-roussel Jan 22, 2026
3ee5604
Apply suggestion from @bakpaul
olivier-roussel Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/postinstall-fixup/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Post-install scripts
if(NOT SOFA_BUILD_RELEASE_PACKAGE)
if(NOT SOFA_BUILD_RELEASE_PACKAGE AND NOT CMAKE_SYSTEM_NAME STREQUAL Windows)
return()
endif()

if(TARGET Sofa.Qt)
if(TARGET Sofa.Qt AND SOFA_BUILD_RELEASE_PACKAGE)
find_package(Qt5 COMPONENTS Gui REQUIRED)
get_target_property(qt5gui_loc Qt5::Gui LOCATION_RELEASE)
get_filename_component(QT_LIB_DIR "${qt5gui_loc}" DIRECTORY)
Expand Down
5 changes: 0 additions & 5 deletions tools/postinstall-fixup/windows-postinstall-fixup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,3 @@ move_metis "$INSTALL_DIR"
cd "$INSTALL_DIR" && find -name "*.dll" -path "*/plugins/*" | while read lib; do
cp "$lib" "$INSTALL_DIR_BIN"
done

# Copy all collection libs in install/bin to make them easily findable
cd "$INSTALL_DIR" && find -name "*.dll" -path "*/collections/*" | while read lib; do
cp "$lib" "$INSTALL_DIR_BIN"
done