-
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: First-class buffer shorthands #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pkg.pr.new packages
benchmark commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐫 !
apps/typegpu-docs/src/content/examples/image-processing/ascii-filter/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove write
method from bufferUsage
.createBuffer(Camera, cameraInitial) | ||
.$usage('uniform') | ||
.$name('camera'); | ||
const camera = root.createUniform(Camera, cameraInitial).$name('camera'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert to buffer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎾
Changes:
['~unstable']
anymore).buffer
on shorthands now carries the proper flags of the buffer on the type.$
shorthand to more resources, apart from just the bind group layouts