Split dev assets and prod assets #99
Conversation
There was a problem hiding this comment.
Also, sometimes developer wants to use mix assets.build on the dev mode (the same command which Github bot uses for building assets).
I'd be good to parematrize this alias so we have e.g. mix assets.build dev or mix assets.build deploy
This will have to be changed in README too (see contributing section)
.gitignore
Outdated
| @@ -31,3 +31,4 @@ live_debugger-*.tar | |||
|
|
|||
| node_modules/ | |||
|
|
|||
| /priv/static/dev/ | |||
There was a problem hiding this comment.
| /priv/static/dev/ | |
| /priv/static/dev/ | |
config/config.exs
Outdated
| @@ -11,6 +11,12 @@ if config_env() == :dev do | |||
| ~w(js/app.js --bundle --minify --sourcemap=external --target=es2020 --outdir=../priv/static/), | |||
| cd: Path.expand("../assets", __DIR__), | |||
| env: %{"NODE_PATH" => Path.expand("../deps", __DIR__)} | |||
| ], | |||
| dev: [ | |||
There was a problem hiding this comment.
I'd change naming to e.g. deploy_build and dev_build to emphasize that it is executed by bot after merge
config/config.exs
Outdated
| @@ -23,6 +29,15 @@ if config_env() == :dev do | |||
| --minify | |||
| ), | |||
| cd: Path.expand("../assets", __DIR__) | |||
| ], | |||
| live_debugger_dev: [ | |||
There was a problem hiding this comment.
same here: dev_build and deploy_build
lib/live_debugger/endpoint.ex
Outdated
| if Mix.env() == :dev do | ||
| plug(Plug.Static, at: "/assets", from: {:live_debugger, "priv/static/dev"}, gzip: false) | ||
| end |
There was a problem hiding this comment.
You mean to move plug(Plug.Static, at: "/assets", from: :live_debugger, gzip: false) to else? Because then priv/static/client.js won't be served in dev and I don't have better idea how to do it.
There was a problem hiding this comment.
Oh, I forgot about client.js - it should be served both in dev and prod.
There was a problem hiding this comment.
I know that it wasn't a scope of this task, but it'd be cool if you moved client.js to the assets folder and perform some kind of bundling on it to.
The current problem is that we currently serve client.js as it is - ideally we'd like a similar process for it as we have for assets/app.js file.
No description provided.