test: biquad tests #722
Open
test: biquad tests #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msluszniak
reviewed
Oct 8, 2025
packages/react-native-audio-api/common/cpp/test/src/biquad/BiquadFilterChromium.cpp
Show resolved
Hide resolved
vltkv
force-pushed
the
test/biquad-tests
branch
from
c9a7504 to
ebb69ca
Compare
vltkv
requested review from
maciejmakowski2003,
mdydek,
michalsek and
miloszwielgus
msluszniak
reviewed
Oct 14, 2025
| double a2 = coeffs.a2; | ||
|
|
||
| for (size_t k = 0; k < frequency.size(); ++k) { | ||
| if (frequency[k] < 0 || frequency[k] > 1) { |
There was a problem hiding this comment.
Suggested change
| if (frequency[k] < 0 || frequency[k] > 1) { | |
| if (frequency[k] < 0.0 || frequency[k] > 1.0) { |
| } | ||
|
|
||
| auto omega = -PI * frequencyArray[i] / context_->getNyquistFrequency(); | ||
| auto omega = -PI * frequencyArray[i]; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh, I see: static constexpr float PI = std::numbers::pi_v<float>; nvm then
|
|
||
| auto omega = -PI * frequencyArray[i] / context_->getNyquistFrequency(); | ||
| auto omega = -PI * frequencyArray[i]; | ||
| auto z = std::complex<float>(cos(omega), sin(omega)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-205
Introduced changes
Checklist