Feat/worklet runner performance improvement #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poneciak57
requested review from
maciejmakowski2003,
mdydek,
michalsek,
miloszwielgus,
piaskowyk,
tjzel and
vltkv
tjzel
reviewed
Oct 9, 2025
|
|
||
| /// @note We want to avoid automatic destruction as | ||
| /// when runtime is destroyed, underlying pointer will be invalid | ||
| char unsafeWorklet[sizeof(jsi::Function)]; |
There was a problem hiding this comment.
You could store <worklets::SerializableWorklet> as it does the same memoization as well (see RetainingSerializable super class).
There was a problem hiding this comment.
ill check this out
packages/react-native-audio-api/common/cpp/audioapi/core/utils/worklets/WorkletsRunner.cpp
Show resolved
Hide resolved
| #if RN_AUDIO_API_ENABLE_WORKLETS | ||
| unsafeRuntimePtr = &strongRuntime->getJSIRuntime(); | ||
| strongRuntime->executeSync( | ||
| [this, shareableWorklet](jsi::Runtime &rt) -> jsi::Value { |
There was a problem hiding this comment.
The use of this here might result in crashes during reloads and in brownfield apps.
There was a problem hiding this comment.
it is calling lambda synchronously do you still think that it would cause a crash ?
Comment on lines
+72
to
+80
| std::optional<jsi::Value> WorkletsRunner::executeOnRuntimeUnsafe( | ||
| const std::function<jsi::Value(jsi::Runtime &)> &&job) const | ||
| noexcept(noexcept(job)) { | ||
| #if RN_AUDIO_API_ENABLE_WORKLETS | ||
| return job(*unsafeRuntimePtr); | ||
| #else | ||
| return std::nullopt; | ||
| #endif | ||
| }; |
There was a problem hiding this comment.
If WorkletsRunner is not tied to the lifetime of the runtime this will crash during reloads and in brownfields.
michalsek
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved performance of worklet runner.
Introduced changes
Checklist