[WIP] chore: Add Fabric support in the macos-example #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency overridding
MatiPl01
force-pushed
the
@matipl01/fabric-in-macos-example
branch
from
9e1460e to
59b01df
Compare
MatiPl01
requested review from
kmagiera,
piaskowyk and
tomekzaw
as code owners
MatiPl01
changed the base branch from
main
to
@matipl01/example-apps-setup-cleanup
MatiPl01
force-pushed
the
@matipl01/example-apps-setup-cleanup
branch
from
cae829d to
6fddb59
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps
macos-exampleRN version to one running on Fabric by default.It also bumps some other dependencies and adds
react-native-safe-area-contextmock (as this library doesn't support Fabric on macos yet). Unfortunately,react-native-safe-area-contextis also used by stack navigator and it seems that adding this mock breaks navigation as navigator no longer works as expected.What is more, transformations on macos seem to be broken. It looks as if the
centertransform origin was in thetop leftcorner of the view and changing it tobottom rightresults in view being transformed relative to the center.Example recording
Event though the app starts, it looks weird
Screen.Recording.2025-01-22.at.16.06.09.1.mp4
Issues
I noticed some issues that I reported on the
react-native-macosrepo:transformOriginplacement (Transform origin center results in transformation relative to the top left corner microsoft/react-native-macos#2361)