Skip to content

Conversation

@MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Dec 7, 2025

Summary

This PR adds playwright setup for web e2e tests. It also adds the example file for the fix implemented in #8567 and implements the first e2e test that checks if the example works properly.

Comparison

I compared test results for the working and non-working implementation and all of them work as expected. To change the current working implementation to non-working, you can simply remove the following lines of code from the packages/react-native-reanimated/src/createAnimatedComponent/AnimatedComponent.tsx:

while (dummyClone?.firstChild) {
  element.appendChild(dummyClone.firstChild);
}
delete element.dummyClone;

For incorrect implementation

Screenshot 2025-12-07 at 01 10 21

For correct implementation

Screenshot 2025-12-07 at 01 28 38

@MatiPl01 MatiPl01 self-assigned this Dec 7, 2025
@MatiPl01 MatiPl01 requested a review from tjzel December 8, 2025 15:48
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatiPl01 MatiPl01 added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 8fc6f1b Dec 9, 2025
12 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/web-e2e-tests-with-playwright branch December 9, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants