fix(Android): closing animation on preloaded screen #2945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kligarski <[email protected]>
|
Superseded by #3062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2940
Description
When user goes to preloaded screen closing animation can be observed. It's because we're changing current top, but going to the screen that's already in the stack. Unfortunately the change of
activityStateis independent as it's a prop. So, when we determine that the screen was already on stack, we don't know that it just changed to active from inactive.Changes
This PR filters out inactive screens in stack, so it doesn't keep track of preloaded screens.
Screenshots / GIFs
2940-before.mov
2940-after.mov
Test code and steps to reproduce
See
Test2940.tsx