refactor(Android, FormSheet v5): Extract FormSheetLifecycleCoordinator for cleaner dialog event handling#4252
Open
t0maboro wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Android FormSheet (v5) implementation by extracting dialog lifecycle event wiring (show/cancel/backdrop click) from FormSheetDialogManager into a dedicated FormSheetLifecycleCoordinator, aiming to simplify responsibilities and improve maintainability.
Changes:
- Introduced
FormSheetLifecycleCoordinatorto centralizeBottomSheetDialogshow/cancel handling and dimming backdrop click wiring. - Updated
FormSheetDialogManagerto delegate lifecycle listener setup/teardown to the new coordinator. - Removed now-redundant private listener-setup methods from
FormSheetDialogManager.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| android/src/main/java/com/swmansion/rnscreens/gamma/modals/formsheet/FormSheetLifecycleCoordinator.kt | New coordinator class encapsulating dialog show/cancel + backdrop click listener management. |
| android/src/main/java/com/swmansion/rnscreens/gamma/modals/formsheet/FormSheetDialogManager.kt | Delegates lifecycle listener responsibilities to the new coordinator and removes duplicated logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 1 for refactoring
FormSheetDialogManagerarchitecture on Android. This PR extracts the native dialog lifecycle management into a dedicated class.Changes
Before & after - visual documentation
N/A - refactor
Test plan
N/A - refactor
Checklist