chore(Examples): Drop local eslint plugin#4260
Open
t0maboro wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-unneeded local ESLint plugin from the example apps workspace, reverting the examples’ lint setup to the state before the custom require-top-level-exports rule was introduced.
Changes:
- Drops
eslint-plugin-local-rulesfromapps/package.jsonand prunes it fromapps/yarn.lock. - Removes the tests-specific ESLint override config that enabled the local rule.
- Deletes the local ESLint plugin implementation from
apps/eslint-plugin-local-rules/.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/yarn.lock | Removes the workspace link/locator entry for the deleted local ESLint plugin. |
| apps/src/tests/.eslintrc.js | Deletes the tests override that enabled the local-rules/require-top-level-exports rule. |
| apps/package.json | Removes the eslint-plugin-local-rules devDependency. |
| apps/eslint-plugin-local-rules/require-top-level-exports.js | Deletes the custom rule implementation. |
| apps/eslint-plugin-local-rules/package.json | Deletes the plugin’s package manifest. |
| apps/eslint-plugin-local-rules/index.js | Deletes the plugin entry point exporting the rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No longer needed after #4201 . Reverting to the state before #3959 .
Changes
Before & after - visual documentation
N/A
Test plan
yarn lintis passingChecklist