refactor(Android, FormSheet v5): Introduce invalidation flags for updates#4262
Open
t0maboro wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Android FormSheetDialogManager update flow to mirror the iOS “diff + invalidate + flush” architecture, introducing explicit invalidation flags and deferring all work into a single coordinated flushPendingUpdates() pass.
Changes:
- Added
FormSheetInvalidationFlagsto track presentation/appearance/behavior invalidations. - Refactored
applyConfigto compute invalidations instead of performing immediate side effects. - Centralized update execution into
flushPendingUpdates()with dedicated update helpers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| android/src/main/java/com/swmansion/rnscreens/gamma/modals/formsheet/FormSheetInvalidationFlags.kt | Adds a new invalidation-flags holder for coordinating updates. |
| android/src/main/java/com/swmansion/rnscreens/gamma/modals/formsheet/FormSheetDialogManager.kt | Switches from immediate updates to invalidation + flush-based update execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the iOS architecture (which has distinct Presentation, Appearance, and Behavior providers along with update flags), this PR introduces an
InvalidationFlagsforFormSheetDialogManageronAndroid.Instead of applying configuration changes when props change, the
applyConfigmethod now evaluates what changed, raises the appropriate flags, and defers the actual execution to a coordinatedflushPendingUpdatespass.Note: as for iOS, reopening the sheet automatically invalidates both
AppearanceandBehavior. This ensures the nativeBottomSheetBehaviorand layout are strictly synchronized with the React Native state, preventing stale configurations on re-mounts.Changes
FormSheetInvalidationFlagsflushPendingUpdatesBefore & after - visual documentation
N/A - refactor
Test plan
N/A - refactor
Checklist