refactor(test): add scenario for test-stack-simple-nav#4270
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a manual test scenario document for the Stack v5 “simple navigation” screen in the example app, describing expected push/pop behavior and platform-specific back navigation interactions.
Changes:
- Added a new
scenario.mddocumenting push/pop flows across Home/A/B, including re-push behavior androuteKeyexpectations. - Documented iOS-native back interactions (header back + edge-swipe) and Android limitations, plus E2E automation notes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LKuchno
marked this pull request as draft
July 7, 2026 08:57
…oid for back gesture and back button options
LKuchno
marked this pull request as ready for review
July 7, 2026 10:03
kkafar
approved these changes
Jul 16, 2026
kkafar
left a comment
Member
There was a problem hiding this comment.
In general I'm against naming such details as background colours in the scenario description. It can very easily go out of date.
This is a minor however. I recommend to think about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1601
This PR adds a comprehensive manual test scenario for the gamma/v5
StackContainer's simple push/pop navigation, and adjusts thetest-stack-simple-navscreen so the scenario can be exercised on both platforms.The scenario documents the full lifecycle from root (Home) through stacking/unstacking screens A and B, covering:
It validates that each push creates a new instance with a unique
routeKey, that a preserved (not recreated) screen keeps itsrouteKeyon pop, and that the root screen (Home) cannot be popped. Edge cases (re-pushing an already-present route, rapid tapping push/pop, route-key uniqueness) are included.The scenario also documents the platform launch difference: iOS runs from the in-app scenario menu, while Android must be launched directly via
apps/App.tsx(renderingTestStackSimpleNavas the root). This is the current workaround for the Android back-button limitation (issue #1459), where the native back button and system gesture-back only pop the stack when theStackContaineris at the root rather than nested inside the example app's navigation.Changes
index.tsx): AddedheaderConfigwith atitleto the Home, A, and B routes. Rendering a header makes the native back button appear on non-root screens (including on Android), which is required to test the header-back-button and gesture-back flows.scenario-description.ts): Renamed the scenario from"Simple navigation scenario"to"Simple stack navigation".scenario.md): Added the manual scenario documenting all push/pop flows, native header-back-button and edge-swipe / system gesture-back interactions,routeKeybehavior, per-platform launch instructions, and edge cases (re-pushing the same route, rapid tapping, root-screen protection). E2E automation is noted as TBD.