fix freeze boundary#4358
Open
noma4i wants to merge 1 commit into
Open
Conversation
Author
|
Maybe it's a bad idea. Who knows |
Member
|
Hi, @noma4i. Thanks for the PR. Interaction between the screen and freeze is a very delicate topic. In order to consider this PR we would need:
Also, as we're currently actively developing v5 of the library, our capacity to review and test such a significant change is limited and it's unlikely that this PR is going to land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
DelayedFreezeinsideAnimatedScreen.Currently, the freeze boundary wraps the native screen host. During rapid tab switches, this can prevent native props such as
activityState, z-index, and pointer-event updates from reaching the native screen while it is frozen. Freezing only the screen content preserves the intended content-freezing behavior while keeping the native host responsive to navigation state changes.Changes
DelayedFreezefrom aroundAnimatedScreento its children.AnimatedScreenprops and native event wiring outside the freeze boundary.Test plan
Use the following minimal example, then tap Toggle screen state repeatedly:
Expected result: the native screen host receives every
activityStateupdate while its children remain frozen when inactive.Checklist