docs: Remove benefits section for create-with-session command#6
Closed
clawdbot-silly-waddle wants to merge 2 commits intosokripon:mainfrom
Closed
docs: Remove benefits section for create-with-session command#6clawdbot-silly-waddle wants to merge 2 commits intosokripon:mainfrom
clawdbot-silly-waddle wants to merge 2 commits intosokripon:mainfrom
Conversation
The create-with-session command and its 'new' alias are already in upstream/main, so the benefits section is no longer needed.
- **lint.yml**: Run linter (ruff) and type checking (mypy) on every push and PR
- **tests.yml**: Run basic tests that don't require email sending on every push and PR
- **email-tests.yml**: Run tests that require Postmark email sending only on manual trigger
Benefits:
- Linting runs fast on every PR without waiting for long test runs
- Basic API tests run on every PR without requiring Postmark secrets
- Email sending tests only run when manually triggered by maintainer with secrets
- Uses pytest markers ("flow") to separate tests by dependencies
This fixes the issue where PRs from forks fail due to missing Postmark secrets.
Contributor
Author
|
Closing to replace with new PR for CI workflow splitting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create-with-session command and its 'new' alias are already included in upstream/main, so the benefits section explaining why this command is useful is no longer needed.
This PR simply removes the "Benefits of create-with-session" section from README.md to keep documentation clean and accurate.