fix(web): add French home copy for the rebuilt dashboard - #1034
Closed
tobySolutions wants to merge 4 commits into
Closed
fix(web): add French home copy for the rebuilt dashboard#1034tobySolutions wants to merge 4 commits into
tobySolutions wants to merge 4 commits into
Conversation
Keeps Token and Wallet in English per the locale guidance; jeton and portefeuille are not what French practitioners say.
Contributor
Greptile SummaryAdds ten French translations for upcoming rebuilt-dashboard balance and first-run copy, retaining the prescribed English terms “Token” and “Wallet.” Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (4): Last reviewed commit: "Merge branch 'main' into fix/fr-home-cop..." | Re-trigger Greptile |
Collaborator
|
this will be caught by the translation bot that has the language context |
Collaborator
Author
Understood sir. Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
French for the balance card copy #1004 adds in English.
Token and Wallet stay in English.
jetonandportefeuillearen't what French practitioners say, and the locale guidance lists both as forbidden. Casing follows the rest of the catalog, which runs about 190:11 for Token and 357:22 for Wallet.Split out from #1004 because #1022 made it a CI failure for one PR to change English and French together. Order doesn't matter, the keys just sit unused until #1004 lands. Three now-unused keys in the same block are left for a follow-up.