feat(spc): add user role to members list, remove name - #1041
Conversation
nbaztec
commented
Jul 31, 2026
- Members table now shows each member's project role instead of their editable name
- Removed the free-form Name column that could go stale when users edited their profile
- Delete action collapsed to a compact trash icon
- "Role" column label added to the interface
|
@nbaztec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR replaces editable member names with project roles in the private-channel members list.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "handle project membership revoke for SPC..." | Re-trigger Greptile |
| // Invites require project membership, so INNER JOIN is safe. | ||
| const USER_JOINS = ` | ||
| INNER JOIN users u ON u.id = pcu.user_id | ||
| INNER JOIN project_members pm ON pm.project_id = pcu.project_id AND pm.user_id = pcu.user_id |
There was a problem hiding this comment.
Project membership hides workspace rows
When an invited user's project membership is removed, the new INNER JOIN makes their persisted private-channel row disappear from list and lookup operations, causing management requests to return 404 and preventing the row from being deleted through the API. The same join in create can fail after the insert and external registration have succeeded when membership is removed during an invitation, leaving partial state that conflicts on retry.
Knowledge Base Used: sdp-api Data Layer