Skip to content

fix(web): stop the filter count appearing twice on the transactions toolbar #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobySolutions merged 6 commits into from
Aug 6, 2026
Merged

fix(web): stop the filter count appearing twice on the transactions toolbar #1097

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c3dab6
fix(web): stop the active filter count vanishing into its own badge
tobySolutions Aug 4, 2026
5f601dc
fix(web): stop the filter count appearing twice on the transactions t…
tobySolutions Aug 4, 2026
b92f99f
Merge branch 'main' into fix/filter-count-badge-contrast
tobySolutions Aug 6, 2026
4734a5d
Merge branch 'main' into fix/filter-count-badge-contrast
tobySolutions Aug 6, 2026
b491e9f
Merge branch 'main' into fix/filter-count-badge-contrast
tobySolutions Aug 6, 2026
69a4d2f
Merge branch 'main' into fix/filter-count-badge-contrast
tobySolutions Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions apps/sdp-web/src/app/dashboard/payments/transactions/transactions-workspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,12 +614,11 @@ export function TransactionsWorkspace({
aria-controls="payments-transaction-advanced-filters"
onClick={() => setFiltersOpen((open) => !open)}
>
{/* No count badge here: "N active" renders directly below on the
same condition, so the badge repeated it in a less useful form —
a bare number, crowded against the button edge, next to a line
that says what the number actually means and offers to clear it. */}
{t("DashboardPayments.transactions.filters")}
{advancedFilterCount > 0 ? (
<span className="rounded-full bg-primary px-1.5 py-0.5 text-[11px] text-white">
{advancedFilterCount}
</span>
) : null}
</Button>
<Button
type="button"
Expand Down
Loading