Open
Conversation
grod220
commented
Mar 18, 2026
Comment on lines
+2
to
+11
| "checks": [ | ||
| "programResult", | ||
| { | ||
| "allResultingAccounts": { | ||
| "data": true, | ||
| "executable": true, | ||
| "lamports": true, | ||
| "owner": true, | ||
| "space": true | ||
| } |
Member
Author
There was a problem hiding this comment.
These are the default mollusk checks except for dropping the returnData conformance. The short circuiting in the account sizing check creates a divergence given it won't always CPI.
Member
Author
|
Hmm. Failing CI is not related to the Mollusk bump (new version is now being pulled in). Going to investigate and re-request review after passing. |
Member
Author
|
Now ready! |
febo
reviewed
Mar 23, 2026
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Looks good – I left a few simple comments.
grod220
force-pushed
the
create-pt-2
branch
2 times, most recently
from
d79f768 to
14826b5
Compare
Co-authored-by: Peter Keay <[email protected]>
Member
Author
|
@febo ready 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the remaining part of the create flow.
Dependencies
Think it's fine to move forward with this PR, but note it depends on a number of PRs currently in flight:
Changes of note:
return_datarequirement given heuristics on skipping CPIs for account sizing.