Skip to content

fix: 🤔 sd-tags paired with floating labels should always be size 'sm' #2882

Description

@martascorreia

Current behavior

When using the sd-tags inside the sd-combobox and sd-select with floating labels enabled, the tags take the size set for the components.

Expected behavior

The sd-tags when paired with floating labels should always be size small 'sm', independently of the size of the component, to ensure the height of the overall component stays the same.

The documentation section 'Multiple' in both and 'Use Tags' in sd-select should also inform the user that sd-tags are always small.

Steps to reproduce

  1. Go to SDS Storybook -> sd-combobox
  2. Go to the Screenshots -> SizexMultiple
  3. You can see the examples for the floating labels use lg and md size tags because these are the sizes set to the component, instead of always sm.

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Developmentneeds changes in codeOperationsIdentifies issues to track operation efforts

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions