fix(MainHeader): button bottom border flicker #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Feel free to close in favour of #1194 |
amirhhashemi
requested changes
Jun 7, 2025
There was a problem hiding this comment.
My only concern is that the border color is defined in two places simultaneously, which could lead to conflicts. Currently, border-b-blue-500 is defined after border-transparent in the Tailwind output CSS file, so it overrides border-transparent. However, if we change border-transparent to something else in the future, this could cause some confusion.
I suggest using inactiveClass to apply border-transparent only when the link is not active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description(required)
Fixes flicker because border starts off being 0px, now it is transparent, so only the color transitions.