-
Notifications
You must be signed in to change notification settings - Fork 317
Update Dependencies #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependencies #1203
Conversation
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think twoslash is not enabled by default in the recent versions of SolidBase. Removing the twoSlash: false
line in the app.config.ts
file should fix the eslint error.
looks like the error comes from the eslint config. ill have to update it so it can be used with json |
Eslint 9 has some breaking changes. The new Flat Config is now the recommended way to configure it, which is very different from the old format. Unless you've done this before, I suggest downgrading Eslint to the previous version (v8) for now, as it may take a lot of time to figure this out—and it might not be worth the effort. I’ll try to take a deeper look and upgrade it myself later since I’ve done it before. But if you’re okay with a little headache and want to do it yourself, check out the docs. |
@amirhhashemi have done it before so i can handle it. just didn't have the time to do it today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solid-mdx
is no longer a dependency of SolidBase, so you can safely remove it.
Co-authored-by: Amir Hossein Hashemi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solid-mdx
package should be removed
Description(required)
Update dependencies that are outdated.