Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname override to AI upstream customHost setting #10640

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andy-fong
Copy link

Description

  • API change for setting hostname when customHost is use for AI Upstream

API changes

new field hostname is added to the customHost message in ai.proto

Code changes

CI changes

Docs changes

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@andy-fong andy-fong requested a review from a team as a code owner February 20, 2025 00:00
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7831

Copy link

github-actions bot commented Feb 20, 2025

Visit the preview URL for this PR (updated for commit 6094ff5):

https://gloo-edge--pr10640-andyfong-ai-upstream-ne3sbj5y.web.app

(expires Fri, 28 Feb 2025 15:28:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants