Skip to content

Commit

Permalink
Update to Go 1.24 and address compilation errors (#56)
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanrolds authored Feb 19, 2025
1 parent 2e54b7c commit de5cb29
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up Go 1.22.2
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.22.2
go-version-file: go.mod
- uses: actions/cache@v3
with:
path: ~/go/pkg/mod
Expand Down
6 changes: 6 additions & 0 deletions changelog/v0.10.0/go-124.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
changelog:
- type: BREAKING_CHANGE
description: >
Bump dependencies to support Go 1.24
issueLink: https://github.com/solo-io/solo-projects/issues/7609
resolvesIssue: false
2 changes: 1 addition & 1 deletion debugutils/kube_dump.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func KubeDumpOnFail(out io.Writer, namespaces []string, additionalCommands Names
if err != nil {
fmt.Fprintf(out, "getting kube dump failed: %v", err)
}
fmt.Fprintf(out, dump)
fmt.Fprint(out, dump)
}
}

Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/solo-io/k8s-utils

go 1.23.0
go 1.24

require (
github.com/avast/retry-go v2.2.0+incompatible
Expand All @@ -16,7 +16,7 @@ require (
github.com/onsi/gomega v1.35.1
github.com/pkg/errors v0.9.1
github.com/rotisserie/eris v0.1.1
github.com/solo-io/go-utils v0.27.4
github.com/solo-io/go-utils v0.28.4
github.com/spf13/afero v1.6.0
go.uber.org/zap v1.27.0
golang.org/x/sync v0.8.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,8 @@ github.com/shopspring/decimal v1.3.1/go.mod h1:DKyhrW/HYNuLGql+MJL6WCR6knT2jwCFR
github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=
github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
github.com/solo-io/go-utils v0.27.4 h1:/VOXUZTsIfnP+aWeWdkiWI4hCyF8nODOr1x+TX+e+dk=
github.com/solo-io/go-utils v0.27.4/go.mod h1:xJncbCIrp5iovb95MReJQFf88q3P23NgB1RyGckzq7k=
github.com/solo-io/go-utils v0.28.4 h1:IH3p/CttV5kzRgxBgk+beynbdFBQyxNFN2bOsgK1nGs=
github.com/solo-io/go-utils v0.28.4/go.mod h1:/V0ovlR+tGhb4+QNYIffKscuhtUIEoN29mJhWjYLYA4=
github.com/spf13/afero v1.6.0 h1:xoax2sJ2DT8S8xA2paPFjDCScCNeWsg75VG0DLRreiY=
github.com/spf13/afero v1.6.0/go.mod h1:Ai8FlHk4v/PARR026UzYexafAt9roJ7LcLMAmO6Z93I=
github.com/spf13/cast v1.3.1/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE=
Expand Down
6 changes: 3 additions & 3 deletions installutils/helminstall/installer.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (i *installer) Install(ctx context.Context, installerConfig *types.Installe
}

if !installerConfig.DryRun && installerConfig.PreInstallMessage != "" {
fmt.Fprintf(i.out, installerConfig.PreInstallMessage)
fmt.Fprint(i.out, installerConfig.PreInstallMessage)
} else {
i.defaultPreInstallMessage(installerConfig)
}
Expand Down Expand Up @@ -106,7 +106,7 @@ func (i *installer) Install(ctx context.Context, installerConfig *types.Installe
return err
}
if !installerConfig.DryRun && installerConfig.PostInstallMessage != "" {
fmt.Fprintf(i.out, installerConfig.PostInstallMessage)
fmt.Fprint(i.out, installerConfig.PostInstallMessage)
} else {
i.defaultPostInstallMessage(installerConfig)
}
Expand All @@ -116,7 +116,7 @@ func (i *installer) Install(ctx context.Context, installerConfig *types.Installe
}

if installerConfig.DryRun {
fmt.Fprintf(i.out, rel.Manifest)
fmt.Fprint(i.out, rel.Manifest)
}

return nil
Expand Down

0 comments on commit de5cb29

Please sign in to comment.