Restore legacy hashing behavior #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirNexus
approved these changes
Jun 26, 2024
| // | ||
| // Deprecated: due to hashing implemention only using field values. The omission | ||
| // of the field name in the hash calculation can lead to hash collisions. | ||
| // Prefer the HashUnique function instead. | ||
| func (m {{ (msgTyp .).Pointer }}) Hash(hasher hash.Hash64) (uint64, error) { |
There was a problem hiding this comment.
Does this comment lead to IDE's knowing the function is deprecated? I suppose what I'm asking is, is the comment here preserved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.Hash()method is used in our envoyfilter and route names in Gloo Mesh. Changing the default behavior of this method would lead to those resources being regenerated due to the name change, which we want to avoid.This PR refactors the work done in #25 and #24 to be contained in a
.HashUnique()method, and preserves the original.Hash()method, marking it as deprecated.