Do not make consumers depend on tools #1403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on a few tools, but export those in our go.mod. This impacts consumers. Notably annoying is our `replaces` and the fact we depend on some really old stuff. https://blog.howardjohn.info/posts/go-tools-command/ is vaguely related to this problem BTW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on a few tools, but export those in our go.mod. This impacts consumers. Notably annoying is our
replacesand the fact we depend on some really old stuff.https://blog.howardjohn.info/posts/go-tools-command/ is vaguely related to this problem BTW
Note to developers
Generally we only merge API changes that are generated via our automation that is triggered by Gloo releases.
If you are creating a branch in order to test the impact of an API change on solo-projects or other repo that depends on
solo-apis, open your PR as a draft or Work in Progress to prevent it from being merged automatically.