Refactor: Use CubicBezierSampler to sample curves
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
commented
Mar 11, 2025
| @@ -49,6 +49,11 @@ class Point3d | |||
|
|
|||
| using value_type = T; | |||
|
|
|||
| Point3d(T x, T y) | |||
There was a problem hiding this comment.
Need new constructors of Point3d and Segment3d.
| { | ||
| } | ||
|
|
||
| CubicBezierSampler() = delete; |
There was a problem hiding this comment.
The helper class template does not need default and copy constructors.
|
|
||
| static size_t sample_to(bezier_type const & c, segment_pad_type & segment, size_t nlocus); | ||
|
|
||
| std::shared_ptr<segment_pad_type> m_segments; |
| }; /* end class CubicBezierSampler */ | ||
|
|
||
| template <typename T> | ||
| size_t CubicBezierSampler<T>::calc_nlocus(Bezier3d<T> const & c, T length) |
There was a problem hiding this comment.
Calculate number of locus based on p0-p3.
| } | ||
|
|
||
| template <typename T> | ||
| size_t CubicBezierSampler<T>::sample_to(bezier_type const & c, segment_pad_type & segments, size_t nlocus) |
There was a problem hiding this comment.
Use a naive sampling algorithm to add segments to a container.
| } | ||
| spad->set(iseg, lastp, tp3); | ||
| ++iseg; | ||
| sample_to(c, *m_segments, nlocus); |
There was a problem hiding this comment.
Add sampled segments to the internal pad.
| template <typename T> | ||
| std::shared_ptr<SegmentPad<T>> CubicBezierSampler<T>::operator()(bezier_type const & curve, size_t nlocus, bool inplace) | ||
| { | ||
| std::shared_ptr<segment_pad_type> segments = inplace ? m_segments : segment_pad_type::construct(m_segments->ndim()); |
There was a problem hiding this comment.
Allow switching between a new or internal pad.
|
@YenPeiChen07 @j8xixo12 please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a (new) common helper class template
CubicBezierSamplerto sample for a single cubic Bezier curve or a sequence of cubic Bezier curves inCurvePad.