fix: prevent plot freeze when euler1d is running #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
approved these changes
Mar 11, 2025
| _subwin.setWidget(PlotArea(self)) | ||
| _subwin.showMaximized() | ||
| _subwin.show() | ||
| self._subwin = self._mgr.addSubWindow(QWidget()) |
There was a problem hiding this comment.
This change to make it an instance member looks good. Thanks, @j8xixo12 .
@Sean20405 please take a look and comment.
|
Oh I know what I've forgot. The plot indeed redraw but the widget (or the sub-window) doesn't refresh. I'll check the functionality more carefully before giving a PR. Thanks to @j8xixo12's help! |
|
Now it updates. Thank you @j8xixo12 . I kind of feel it updates faster than before, but I do not have an evidence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #478 by updating plot object at
setbutton callback function and keep_subwinas an attribute inEuler1DAppto prevent python's garbage collection from delete it because it's reference count is 0.Screenshot :
