refactor(charts): tier-1 consistency pass across the chart collection#33
Merged
Conversation
Contributor
|
Thanks for opening this pull request! 🙌 A maintainer will review it soon. In the meantime, please make sure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consistency / DRY quick-wins across the chart collection (Tier 1 of the refactor plan). Three charts get a patch bump for packaging-relevant changes; the rest are packaging-neutral (verified render/behavior-identical).
Changes
Packaging-neutral (no version bump):
fix(scripts): normalize all 5 chartupgrade.shshebangs to#!/usr/bin/env bash(was#!/bin/bash). upgrade.sh is.helmignore-excluded, so no tarball impact.docs(charts): backfill_helpers.tpldoc-comments in postgresql and redis to match the documented mysql style. Verified render-identical (helm templatebefore/after byte-equal — comments never render).Packaging changes (patch bump + CHANGELOG):
fix(charts): excludeci/from the elasticsearch-eck and kibana-eck package tarballs via.helmignore(CI-only values, matching ghost/unity-mcp-server). → es0.1.13, kibana0.1.6.refactor(metallb-cr): dedupevalues.schema.jsonvia$defs.stringMap+$defs.specExtra(matches the keycloak-cr/keycloak-operator convention). Proven behavior-identical — resolving every$refand dropping$defsyields the exact prior schema. → metallb-cr0.1.2.Also carries a maintainer housekeeping commit removing the now-obsolete DCO sign-off instructions from CONTRIBUTING.md / the PR template.
Not included
type: libraryshared-chart work, which would rework the same helper signatures.Verification
helm lint+make validate(kubeconform) pass on all touched chartsscripts/upgrade-sync/sync.sh --check→ 0 drift🤖 Generated with Claude Code