Skip to content

refactor(charts): tier-1 consistency pass across the chart collection#33

Merged
somaz94 merged 5 commits into
mainfrom
refactor/tier1-consistency
Jul 13, 2026
Merged

refactor(charts): tier-1 consistency pass across the chart collection#33
somaz94 merged 5 commits into
mainfrom
refactor/tier1-consistency

Conversation

@somaz94

@somaz94 somaz94 commented Jul 13, 2026

Copy link
Copy Markdown
Owner

What

Consistency / DRY quick-wins across the chart collection (Tier 1 of the refactor plan). Three charts get a patch bump for packaging-relevant changes; the rest are packaging-neutral (verified render/behavior-identical).

Changes

Packaging-neutral (no version bump):

  • fix(scripts): normalize all 5 chart upgrade.sh shebangs to #!/usr/bin/env bash (was #!/bin/bash). upgrade.sh is .helmignore-excluded, so no tarball impact.
  • docs(charts): backfill _helpers.tpl doc-comments in postgresql and redis to match the documented mysql style. Verified render-identical (helm template before/after byte-equal — comments never render).

Packaging changes (patch bump + CHANGELOG):

  • fix(charts): exclude ci/ from the elasticsearch-eck and kibana-eck package tarballs via .helmignore (CI-only values, matching ghost/unity-mcp-server). → es 0.1.13, kibana 0.1.6.
  • refactor(metallb-cr): dedupe values.schema.json via $defs.stringMap + $defs.specExtra (matches the keycloak-cr/keycloak-operator convention). Proven behavior-identical — resolving every $ref and dropping $defs yields the exact prior schema. → metallb-cr 0.1.2.

Also carries a maintainer housekeeping commit removing the now-obsolete DCO sign-off instructions from CONTRIBUTING.md / the PR template.

Not included

  • Component-label helper parametrization (🟢) is deferred to the Tier 3 type: library shared-chart work, which would rework the same helper signatures.

Verification

  • helm lint + make validate (kubeconform) pass on all touched charts
  • scripts/upgrade-sync/sync.sh --check → 0 drift
  • Render / schema equivalence proven for the packaging-neutral changes
  • CHANGELOG updated for every version-bumped chart

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for opening this pull request! 🙌

A maintainer will review it soon. In the meantime, please make sure:

  • The PR title follows Conventional Commits (feat: / fix: / docs: / ...)
  • Tests are added/updated, or not applicable
  • Docs/README are updated, or not applicable
  • CI is green

@github-actions github-actions Bot added the size/m Medium PR label Jul 13, 2026
@somaz94
somaz94 merged commit 1cb126e into main Jul 13, 2026
10 checks passed
@somaz94
somaz94 deleted the refactor/tier1-consistency branch July 13, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m Medium PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant