Skip to content

refactor(charts): split Service/PVC files + unify schema $defs (tier-2)#34

Merged
somaz94 merged 3 commits into
mainfrom
refactor/tier2-resource-split
Jul 13, 2026
Merged

refactor(charts): split Service/PVC files + unify schema $defs (tier-2)#34
somaz94 merged 3 commits into
mainfrom
refactor/tier2-resource-split

Conversation

@somaz94

@somaz94 somaz94 commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

Tier-2 structural cleanup across the four workload charts (mysql, postgresql, redis, buildkit). Rendered output is unchanged — this is a pure refactor.

#1 — Split Service / PVC into dedicated template files

  • mysql / postgresql / redis: deployment.yaml → Service moved to service.yaml, PVC moved to pvc.yaml (one file per kind).
  • buildkit: statefulset.yaml → Service moved to service.yaml. The PVC stays inline as volumeClaimTemplates (it is not a separate top-level resource), so no pvc.yaml.

#2 — Hoist shared shapes into schema $defs

  • service: inline in all four (byte-identical) → promoted to $defs.service + $ref.
  • persistence: mysql/postgresql already used $defs; redis (base + mountPath) and buildkit (base − existingClaim + mountPath) promoted from inline to $defs.persistence + $ref, each keeping its own shape.
  • $defs order unified to metadataBlock / resources / service / persistence.

Verification

  • Render-equivalence: helm template (persistence on/off × 4 charts = 8 combos) is byte-identical to main after stripping the # Source: path comments.
  • Schema behavior-neutral: recursively resolving $ref yields a schema identical to the original inline schema; JSON well-formed.
  • make lint / make template / make validate (kubeconform) green for all four; helm package tarballs include the new files.

Version bumps

chart version
mysql 0.1.1 → 0.1.2
postgresql 0.1.1 → 0.1.2
redis 0.1.1 → 0.1.2
buildkit 0.1.2 → 0.1.3

CHANGELOG + artifacthub.io/changes updated per chart. Merge triggers release.yml auto-release.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for opening this pull request! 🙌

A maintainer will review it soon. In the meantime, please make sure:

  • The PR title follows Conventional Commits (feat: / fix: / docs: / ...)
  • Tests are added/updated, or not applicable
  • Docs/README are updated, or not applicable
  • CI is green

@github-actions github-actions Bot added the size/l Large PR label Jul 13, 2026
@somaz94
somaz94 merged commit 0b07fca into main Jul 13, 2026
9 checks passed
@somaz94
somaz94 deleted the refactor/tier2-resource-split branch July 13, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/l Large PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant