refactor(charts): split Service/PVC files + unify schema $defs (tier-2)#34
Merged
Conversation
Contributor
|
Thanks for opening this pull request! 🙌 A maintainer will review it soon. In the meantime, please make sure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tier-2 structural cleanup across the four workload charts (
mysql,postgresql,redis,buildkit). Rendered output is unchanged — this is a pure refactor.#1 — Split Service / PVC into dedicated template files
mysql/postgresql/redis:deployment.yaml→ Service moved toservice.yaml, PVC moved topvc.yaml(one file per kind).buildkit:statefulset.yaml→ Service moved toservice.yaml. The PVC stays inline asvolumeClaimTemplates(it is not a separate top-level resource), so nopvc.yaml.#2 — Hoist shared shapes into schema
$defsservice: inline in all four (byte-identical) → promoted to$defs.service+$ref.persistence:mysql/postgresqlalready used$defs;redis(base +mountPath) andbuildkit(base −existingClaim+mountPath) promoted from inline to$defs.persistence+$ref, each keeping its own shape.$defsorder unified tometadataBlock / resources / service / persistence.Verification
helm template(persistence on/off × 4 charts = 8 combos) is byte-identical tomainafter stripping the# Source:path comments.$refyields a schema identical to the original inline schema; JSON well-formed.make lint/make template/make validate(kubeconform) green for all four;helm packagetarballs include the new files.Version bumps
CHANGELOG +
artifacthub.io/changesupdated per chart. Merge triggersrelease.ymlauto-release.