Address coments from review of HA proposal #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SanjayTh
commented
Nov 1, 2022
SanjayTh
commented
- Add Flow sync metadata details and other changes
- Add Flow sync metadata details and other changes
lguohan
reviewed
Nov 1, 2022
lguohan
reviewed
Nov 1, 2022
lguohan
reviewed
Nov 1, 2022
| /** | ||
| * @brief Default result - undefined | ||
| */ | ||
| SAI_DASH_HA_POLICY_RESULT_NONE, |
There was a problem hiding this comment.
what does undefined mean here?
There was a problem hiding this comment.
This is to prevent an unset value taking on a valid value by default and should be explicitly set to one of the other values. This value should not seen on the wire
lguohan
reviewed
Nov 1, 2022
lguohan
reviewed
Nov 1, 2022
lguohan
reviewed
Nov 1, 2022
chrispsommers
requested changes
Nov 8, 2022
chrispsommers
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.