[dash-p4] Add flow_table_id attribute on ENI #669
+77
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 669 in repo sonic-net/DASH |
|
hi @prsunny @marian-pritsak @mukeshmv , trying to bring this up to your radar. This attribute is missing on the ENI level. However, it should not affect the implementation, because we are using the single flow table anyway. |
r12f
reviewed
Feb 25, 2025
| @@ -241,6 +241,7 @@ header flow_data_t { | |||
| bit<32> version; | |||
| dash_flow_action_t actions; | |||
| dash_meter_class_t meter_class; | |||
| bit<32> idle_timeout; | |||
There was a problem hiding this comment.
will be better to split this PR into 2 and only keep the flow table id in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow_table_idattribute on ENI object, ENI can be associated with a specific flow tableflow_enabled_keyattribute of the flow tableflow_ttl_in_millisecondsattribute of the flow table