Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nokia][New Platform][DeviceData] Nokia adds new platforms support (X3B platform) #21710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Nokia][New Platform][DeviceData] Nokia adds new platforms support (X3B platform) #21710

wants to merge 2 commits into from

Conversation

mlok-nokia
Copy link
Contributor

@mlok-nokia mlok-nokia commented Feb 11, 2025 •
edited
Loading

Why I did it

Nokia adds X3B platform support:
Platform: x86_64-nokia_ixr7250_x3b-r0 Hwsku: Nokia-IXR7250-X3B

Work item tracking
  • Microsoft ADO (number only):

How I did it

  1. Add new platform Nokia-IXR7250-X3B. platform string: x86_64-nokia_ixr7250_x3b-r0. Hwsku: Nokia-IXR7250-X3B.
    • Nokia-IXR7250-X3B support VoQ T2 feature. Follow the existing multi-asic chassis design, database-chassis is required to be created and support on the PizzaBox. It means that chassisdb.conf will be defined and used in the platform. To support the database-chassis, docker0 (240.127.1.1) will be used for the redis-chassis.server.
  • Key file platform_env.conf will be defined without "supervisor=1" definition to differentiate the x3b and Chassis Supervisor.

This Platform support requires PR #21709
This PR requires PR #21737 to pass the image build

How to verify it

Install and run the image on X3B platform and verify all features

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202411

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mlok-nokia mlok-nokia requested a review from lguohan as a code owner February 11, 2025 21:16
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia
Copy link
Contributor Author

@judyjoseph @arlakshm and @rlhui This PR is adding the support of Nokia-IXR7250-X3B platform with all device data. It requires the PR #21710 to run on Nokia-IXR7250-X3B platform. Please help to review it.

@mlok-nokia
Copy link
Contributor Author

@tjchadaga @deepak-singhal0408 FYI

@saksarav-nokia
Copy link
Contributor

@saksarav-nokia

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia mlok-nokia force-pushed the nokia-3xb-device-data-and-support branch from af956c5 to a8ebdb1 Compare February 13, 2025 18:09
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia mlok-nokia force-pushed the nokia-3xb-device-data-and-support branch from a8ebdb1 to 397c994 Compare February 13, 2025 18:21
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia mlok-nokia force-pushed the nokia-3xb-device-data-and-support branch from 219266e to f7e82c9 Compare February 18, 2025 22:27
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia
Copy link
Contributor Author

This PR requires PR #21737 to make the image build pass

@mlok-nokia mlok-nokia changed the title [Nokia_IXR7250_X3B] Nokia adds new platform Nokia-IXR7250-X3B device data [Nokia][New Platform][DeviceData] Nokia adds new platforms support (includes X3B platform) Feb 19, 2025
arlakshm
arlakshm reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlok-nokia, is possible to split the PR, one with X3b and one for the other platforms. Makes it easier to cherry-pick

@Pavan-Nokia
Copy link
Contributor

@arlakshm The platforms in the PR are all targeted for the 202411 release. Most of the files in this PR are new files and should not have any trouble being cherry-picked into the 202411 branch.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia mlok-nokia changed the title [Nokia][New Platform][DeviceData] Nokia adds new platforms support (includes X3B platform) [Nokia][New Platform][DeviceData] Nokia adds new platforms support (X3B platform) Feb 25, 2025
@mlok-nokia
Copy link
Contributor Author

mlok-nokia commented Feb 25, 2025 •
edited
Loading

@mlok-nokia, is possible to split the PR, one with X3b and one for the other platforms. Makes it easier to cherry-pick

@arlakshm Based on your suggestion, I have split the PR to 2 PR. This one is for X3B platform. Another PR #21853 is for platform Nokia-IXR7220-H5-64O and Nokia-IXR7220-D4-36D. Please review them both. Thanks

@mlok-nokia mlok-nokia mentioned this pull request Feb 25, 2025
Open
12 tasks
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia mlok-nokia force-pushed the nokia-3xb-device-data-and-support branch from 0a6c77c to 6cd38a2 Compare February 25, 2025 21:14
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mlok-nokia
[Nokia_IXR7250_X3B] Nokia add new platform Nokia-IXR7250-X3B device data
6cd38a2 
Signed-off-by: mlok <[email protected]>

Added new Platform Nokia-IXR7220-D4-36D and Nokia-IXR7220-H5-64O

Fix platform_reboot and trailing space issue

Address review comments by split the device data for x3b

Address review comments by split the device data for x3b
vmittal-msft
vmittal-msft reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@vmittal-msft vmittal-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlok-nokia Can you please share what is the basis of picking these MMU settings ? Also, there was a recent PR to update pg profile settings based on port speed rather than hwsku, please use those settings.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saksarav-nokia
Copy link
Contributor

@mlok-nokia Can you please share what is the basis of picking these MMU settings ? Also, there was a recent PR to update pg profile settings based on port speed rather than hwsku, please use those settings.

@vmittal-msft , Since this is T2 device with same J2C+ 400G ports, we copied the MMU settings from https://github.com/sonic-net/sonic-buildimage/tree/master/device/nokia/x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x400G . Marty has updated the PR with your recent changes from PR #21733

judyjoseph
judyjoseph approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyjoseph
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlakshm arlakshm arlakshm left review comments

@judyjoseph judyjoseph judyjoseph approved these changes

@tjchadaga tjchadaga tjchadaga approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@vmittal-msft vmittal-msft Awaiting requested review from vmittal-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mlok-nokia @mssonicbld @saksarav-nokia @Pavan-Nokia @judyjoseph @vmittal-msft @arlakshm @tjchadaga