-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nokia][New Platform][DeviceData] Nokia adds new platforms support (X3B platform) #21710
base: master
Are you sure you want to change the base?
[Nokia][New Platform][DeviceData] Nokia adds new platforms support (X3B platform) #21710
Conversation
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@judyjoseph @arlakshm and @rlhui This PR is adding the support of Nokia-IXR7250-X3B platform with all device data. It requires the PR #21710 to run on Nokia-IXR7250-X3B platform. Please help to review it. |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
af956c5
to
a8ebdb1
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
a8ebdb1
to
397c994
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
219266e
to
f7e82c9
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR requires PR #21737 to make the image build pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlok-nokia, is possible to split the PR, one with X3b and one for the other platforms. Makes it easier to cherry-pick
@arlakshm The platforms in the PR are all targeted for the 202411 release. Most of the files in this PR are new files and should not have any trouble being cherry-picked into the 202411 branch. |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@arlakshm Based on your suggestion, I have split the PR to 2 PR. This one is for X3B platform. Another PR #21853 is for platform Nokia-IXR7220-H5-64O and Nokia-IXR7220-D4-36D. Please review them both. Thanks |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
0a6c77c
to
6cd38a2
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: mlok <[email protected]> Added new Platform Nokia-IXR7220-D4-36D and Nokia-IXR7220-H5-64O Fix platform_reboot and trailing space issue Address review comments by split the device data for x3b Address review comments by split the device data for x3b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlok-nokia Can you please share what is the basis of picking these MMU settings ? Also, there was a recent PR to update pg profile settings based on port speed rather than hwsku, please use those settings.
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@vmittal-msft , Since this is T2 device with same J2C+ 400G ports, we copied the MMU settings from https://github.com/sonic-net/sonic-buildimage/tree/master/device/nokia/x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x400G . Marty has updated the PR with your recent changes from PR #21733 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
Nokia adds X3B platform support:
Platform: x86_64-nokia_ixr7250_x3b-r0 Hwsku: Nokia-IXR7250-X3B
Work item tracking
How I did it
This Platform support requires PR #21709
This PR requires PR #21737 to pass the image build
How to verify it
Install and run the image on X3B platform and verify all features
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)