Skip to content

Commit

Permalink
Revert "Fail build when test fail (#53)" (#62)
Browse files Browse the repository at this point in the history
Why I did it
In previous PR #53, we fail build when UT fail, it works well in current repo. But UT in sonic-buildimage failed due to redis issue in slave container, which would block submodule update
image

How I did it
Revert previous PR to don't fail build when UT fail for now
  • Loading branch information
yaqiangz authored Dec 30, 2024
1 parent dbaee8b commit b242307
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ $(DHCP6RELAY_TEST_TARGET): $(TEST_OBJS)
$(CXX) $(LDFLAGS) $^ $(LDLIBS) $(LDLIBS_TEST) -o $@

test: $(DHCP6RELAY_TEST_TARGET)
sudo ASAN_OPTIONS=detect_leaks=0 ./$(DHCP6RELAY_TEST_TARGET) --gtest_output=xml:$(DHCP6RELAY_TEST_TARGET)-test-result.xml || { echo 'Tests failed'; exit 1; }
sudo ASAN_OPTIONS=detect_leaks=0 ./$(DHCP6RELAY_TEST_TARGET) --gtest_output=xml:$(DHCP6RELAY_TEST_TARGET)-test-result.xml || true
$(GCOVR) -r ./ --html --html-details -o $(DHCP6RELAY_TEST_TARGET)-code-coverage.html
$(GCOVR) -r ./ --xml-pretty -o $(DHCP6RELAY_TEST_TARGET)-code-coverage.xml

Expand Down

0 comments on commit b242307

Please sign in to comment.