Skip to content

C3000 deactivate the HSUART DMA #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

micas-net
Copy link
Contributor

@micas-net micas-net commented Apr 17, 2025

Why I did it

Intel C3000 CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang.

Work item tracking
  • Microsoft ADO (number only):
  • After the merge, Microsoft will be asked to cherry-pick to the 202411 branch.

How I did it

C3000 deactivate the HSUART DMA

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@micas-net
Copy link
Contributor Author

micas-net commented Apr 17, 2025

This PR fixes the issue reported in sonic-net/sonic-buildimage#22555

Copy link

@AndrewQu-Micas AndrewQu-Micas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the changes

@saiarcot895
Copy link
Contributor

Can you add the description you have in the PR into the patch?

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Subject: [PATCH] C3000 deactivate the HSUART DMA

Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang.
So for DNV CPU, HSUART DMA will be deactivated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. reports and an in “Intel C3000 CPU reports an err,“
  2. Please paste the error.
  3. Is there an errata for this issue? Have you reported this upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. done
  2. done
  3. will check if some one has reported it in kernel.org, if not, then will reported it. will update soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Thank you.
  2. I do not see the copy-pasted error in the commit description (in the added file).
  3. Sounds great. I am looking forward to your findings.

Copy link
Contributor Author

@micas-net micas-net Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I have reported the patch revision on kernel.org
    https://lore.kernel.org/lkml/[email protected]/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@@ -0,0 +1,45 @@
From b63977b0e1421c641495940fafab9502a2a6d659 Mon Sep 17 00:00:00 2001
From: philo <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use your full name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,done!

From b63977b0e1421c641495940fafab9502a2a6d659 Mon Sep 17 00:00:00 2001
From: philo <[email protected]>
Date: Thu, 17 Apr 2025 02:17:18 -0500
Subject: [PATCH] C3000 deactivate the HSUART DMA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a prefix as is common in the Linux kernel git archive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done!

Date: Thu, 17 Apr 2025 02:17:18 -0500
Subject: [PATCH] C3000 deactivate the HSUART DMA

Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma looks strange: Use ,.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,done!

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…tty-8250-HSUART-DMA-be-deactivated-for-DNV-CPU.patch
@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

From b63977b0e1421c641495940fafab9502a2a6d659 Mon Sep 17 00:00:00 2001
From: Philo Shao <[email protected]>
Date: Thu, 17 Apr 2025 02:17:18 -0500
Subject: [PATCH] tty/8250: The HSUART DMA be deactivated for the DNV CPU.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove [PATCH], and use a summary/title in imperative mood, and no dot/period at the end.

tty/8250: Deactivate HSUART for Intel DNV CPU

Subject: [PATCH] C3000 deactivate the HSUART DMA

Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang.
So for DNV CPU, HSUART DMA will be deactivated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Thank you.
  2. I do not see the copy-pasted error in the commit description (in the added file).
  3. Sounds great. I am looking forward to your findings.

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Intel DNV CPU reports an error, indicating that there is a possibility of abnormal serial port functionality and the CPU may hang.
The HSUART DMA will be deactivated for the DNV CPU.

Signed-off-by: Philo Shao<[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space before the <.

Subject: [PATCH] C3000 deactivate the HSUART DMA

Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang.
So for DNV CPU, HSUART DMA will be deactivated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants