-
Notifications
You must be signed in to change notification settings - Fork 186
C3000 deactivate the HSUART DMA #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR fixes the issue reported in sonic-net/sonic-buildimage#22555 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve the changes
Can you add the description you have in the PR into the patch? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Subject: [PATCH] C3000 deactivate the HSUART DMA | ||
|
||
Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang. | ||
So for DNV CPU, HSUART DMA will be deactivated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- reports and an in “Intel C3000 CPU reports an err,“
- Please paste the error.
- Is there an errata for this issue? Have you reported this upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- done
- done
- will check if some one has reported it in kernel.org, if not, then will reported it. will update soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Thank you.
- I do not see the copy-pasted error in the commit description (in the added file).
- Sounds great. I am looking forward to your findings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have reported the patch revision on kernel.org
https://lore.kernel.org/lkml/[email protected]/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@@ -0,0 +1,45 @@ | |||
From b63977b0e1421c641495940fafab9502a2a6d659 Mon Sep 17 00:00:00 2001 | |||
From: philo <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use your full name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,done!
From b63977b0e1421c641495940fafab9502a2a6d659 Mon Sep 17 00:00:00 2001 | ||
From: philo <[email protected]> | ||
Date: Thu, 17 Apr 2025 02:17:18 -0500 | ||
Subject: [PATCH] C3000 deactivate the HSUART DMA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a prefix as is common in the Linux kernel git archive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, done!
Date: Thu, 17 Apr 2025 02:17:18 -0500 | ||
Subject: [PATCH] C3000 deactivate the HSUART DMA | ||
|
||
Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma looks strange: Use ,.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,done!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…tty-8250-HSUART-DMA-be-deactivated-for-DNV-CPU.patch
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
From b63977b0e1421c641495940fafab9502a2a6d659 Mon Sep 17 00:00:00 2001 | ||
From: Philo Shao <[email protected]> | ||
Date: Thu, 17 Apr 2025 02:17:18 -0500 | ||
Subject: [PATCH] tty/8250: The HSUART DMA be deactivated for the DNV CPU. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove [PATCH], and use a summary/title in imperative mood, and no dot/period at the end.
tty/8250: Deactivate HSUART for Intel DNV CPU
Subject: [PATCH] C3000 deactivate the HSUART DMA | ||
|
||
Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang. | ||
So for DNV CPU, HSUART DMA will be deactivated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Thank you.
- I do not see the copy-pasted error in the commit description (in the added file).
- Sounds great. I am looking forward to your findings.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Intel DNV CPU reports an error, indicating that there is a possibility of abnormal serial port functionality and the CPU may hang. | ||
The HSUART DMA will be deactivated for the DNV CPU. | ||
|
||
Signed-off-by: Philo Shao<[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a space before the <.
Subject: [PATCH] C3000 deactivate the HSUART DMA | ||
|
||
Intel DNV CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang. | ||
So for DNV CPU, HSUART DMA will be deactivated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Why I did it
Intel C3000 CPU report a err,there is a possibility that the serial port function will be abnormal and the CPU will hang.
Work item tracking
How I did it
C3000 deactivate the HSUART DMA
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)