Fix for i2c_designware shutdown #497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Designware I2C driver was failing to probe the I2C controller after we kexec to another kernel on some Arista platforms: i2c_designware AMDI0010:00: Unknown Synopsys component type: 0xffffffff
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmenzel
suggested changes
Jul 17, 2025
| @@ -0,0 +1,49 @@ | |||
| From: Justin Oliver <[email protected]> | |||
| Date: 2022-12-12 17:42:20 +0000 | |||
| Subject: Designware I2C driver fails to probe device after kexec | |||
There was a problem hiding this comment.
Please make it a statement and follow the Linux kernel prefix style for the subsystem.
| @@ -0,0 +1,49 @@ | |||
| From: Justin Oliver <[email protected]> | |||
| Date: 2022-12-12 17:42:20 +0000 | |||
There was a problem hiding this comment.
Has this been sent upstream (especially for review)?
There was a problem hiding this comment.
Not yet ,but we could try submitting a patch for review to the Linux community.
There was a problem hiding this comment.
That’d be great. Please give a timeline. (It shouldn’t take longer than five minutes.)
| Date: 2022-12-12 17:42:20 +0000 | ||
| Subject: Designware I2C driver fails to probe device after kexec | ||
|
|
||
| The Designware I2C driver sometimes fails to probe the I2C controller after |
There was a problem hiding this comment.
Please add the error log message from the merge/pull request description.
| defines a `shutdown` procedure for the Designware I2C platform driver. This | ||
| will gracefully bring down the I2C controller, allowing the driver to | ||
| successfully initialize the device with the new kernel. | ||
|
|
There was a problem hiding this comment.
Missing Signed-off-by line.
|
@byu343 , can you address comments? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmenzel
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designware I2C driver was failing to probe the I2C controller after we kexec to another kernel on some Arista platforms:
i2c_designware AMDI0010:00: Unknown Synopsys component type: 0xffffffff