Add check and delay after unbinding ports from old driver #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dypet
approved these changes
Jul 3, 2025
| @@ -45,6 +45,17 @@ function bind_ports_to_uio() | |||
| if [ "$CUR_DRIVER" != "" ] && [ "$CUR_DRIVER" != "$UIO_DRV" ]; then | |||
| echo "Un-binding port $port($PCI_ID) from driver $CUR_DRIVER" | |||
| echo "$PCI_ID" > /sys/bus/pci/drivers/$CUR_DRIVER/unbind | |||
|
|
|||
| # Wait until the device is unbound | |||
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Occasionally in azure pretest, we saw below errors from vpp_ports_setup.sh,
2025-07-01T07:42:08.524762+00:00 sonic vpp_ports_setup.sh[1678]: Un-binding port 0000:04:00.0(0000:04:00.0) from driver virtio-pci
2025-07-01T07:42:08.596306+00:00 sonic vpp_ports_setup.sh[1678]: Binding port 0000:04:00.0(0000:04:00.0) to driver uio_pci_generic
2025-07-01T07:42:08.610076+00:00 sonic vpp_ports_setup.sh[1678]: /usr/bin/vpp_ports_setup.sh: line 52: echo: write error: Device or resource busy
I suspect this is due to unbind has not completed yet when bind is called.
what this PR does
Add check to make sure unbind is successful before executing bind.