Fix review comments

Signed-off-by: Stephen Sun <[email protected]>
sonic-net · Feb 14, 2025 · 11034f3 · 11034f3
1 parent ad06ae8
commit 11034f3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/syncd/FlexCounterManager.cpp b/syncd/FlexCounterManager.cpp
@@ -110,7 +110,8 @@ void FlexCounterManager::bulkAddCounter(
     SWSS_LOG_ENTER();
 
     auto fc = getInstance(instanceId);
-    sai_object_type_t objectType = VidManager::objectTypeQuery(vids[0]); // VID and RID will have the same object type
+
+    sai_object_type_t objectType = VidManager::objectTypeQuery(vids.at(0)); // VID and RID will have the same object type
 
     fc->bulkAddCounter(objectType, vids, rids, values);
 

diff --git a/syncd/Syncd.cpp b/syncd/Syncd.cpp
@@ -2794,7 +2794,7 @@ sai_status_t Syncd::processFlexCounterEvent(
     auto strVids = key.substr(delimiter + 1);
     auto vidStringVector = swss::tokenize(strVids, ',');
 
-    if (fromAsicChannel && op == SET_COMMAND && vidStringVector.size() > 1)
+    if (fromAsicChannel && op == SET_COMMAND && (!vidStringVector.empty()))
     {
         std::vector<sai_object_id_t> vids;
         std::vector<sai_object_id_t> rids;