[sonic-sairedis] Moved SAI submodule to SAI master with compatibility-oriented code changes #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
reviewed
Feb 11, 2025
unittest/syncd/TestWorkaround.cpp
Outdated
| @@ -1,69 +0,0 @@ | |||
| #include <cstdint> | |||
kcudnik
requested changes
Feb 11, 2025
unittest/syncd/Makefile.am
Outdated
| @@ -17,7 +17,6 @@ tests_SOURCES = main.cpp \ | |||
| TestNotificationHandler.cpp \ | |||
| TestMdioIpcServer.cpp \ | |||
| TestPortStateChangeHandler.cpp \ | |||
| TestWorkaround.cpp \ | |||
There was a problem hiding this comment.
bring this back! as it tests other importnat thinkgs !
unittest/syncd/TestWorkaround.cpp
Outdated
| @@ -1,69 +0,0 @@ | |||
| #include <cstdint> | |||
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
this PR is in conflict with #1531 why both PRs are moving SAI pointer to different location, what's the reason here ? |
Initially, we wanted to move the SAI pointer to the latest master of SAI. Yet, as you can see, the build failed even after I added the changes to delete incompatible code. |
|
Basically, the plan is to take #1531 first. This PR will be taken only if it can pass the build and we can make sure it won't break broadcom's SDK. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved SAI submodule to it's latest master in sonic-sairedis. Following SAI commits: