You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. A DASH_OUTBOUND_ROUTING_GROUP may be referenced by one or more DASH_OUTBOUND_ROUTING_ENTRIES. We should be able to delete DASH_OUTBOUND_ROUTING_GROUPS even if related routing entries still exist. The SAI implementation will implicitly delete all routing entries when the routing group is deleted, which is why we need to ignore reference count for these specific objects when validation removal.
i dont quite understand, that you can request to delete all entries even if they are still in use, this will definitely cause inconsistency error, since some attributes will still have attributes SET to that value you deleted, and this will cause in long rung syncd to crash because of inconsistency and reference count error.
The change you are making is not solving actual issue, its one step to collapse everything, later on you will have to make changes in syncd and allow to remove objects which are in use and you will have no choice to crash.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the DASH HLD, we need to be able to delete certain 'parent' SAI objects even when they are still referenced: https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md#18-implicit-deletion-of-sai-objects
E.g. A DASH_OUTBOUND_ROUTING_GROUP may be referenced by one or more DASH_OUTBOUND_ROUTING_ENTRIES. We should be able to delete DASH_OUTBOUND_ROUTING_GROUPS even if related routing entries still exist. The SAI implementation will implicitly delete all routing entries when the routing group is deleted, which is why we need to ignore reference count for these specific objects when validation removal.