Enhance the logic to check capability of bulk counter poll #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
stephenxs
force-pushed
the
check-bulk-counter
branch
from
57f5aa2 to
cd5cd5e
Compare
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
check-bulk-counter
branch
from
cd5cd5e to
55543e8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
BFD test fails |
Signed-off-by: Stephen Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
check-bulk-counter
branch
from
696e427 to
737b802
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the logic to check the capability of the bulk counter poll in
bulkAddObjectm_objectIdsMapINFOwhen a counter is not supported to be bulk-polled to avoid too many log messagesDetails:
In
bulkAddObjectit enables counter polling for a set of objects. A brief flow is the following:SAI_STATS_MODE_READ_AND_CLEARorSAI_STATS_MODE_READ) usingupdateSupportedCounters(which eventually callsquery_stats_capability). All counters that do not support the capability will be removed.SAI_STATS_MODE_BULK_READ_AND_CLEARandSAI_STATS_MODE_BULK_READrespectively).Add the counters to
m_objectIdsMapif they do not support bulk call.Possible error messages in vendor SAI:
An error message can be observed on some platforms if an unsupported counter-polling SAI API is called.
This could happen if the vendor SAI supports a counter polling operation only on part of objects.
In this case, the function
query_stats_capabilityreturns that it supports the operation on the object type. FlexCounter needs to call the counter polling SAI API to check whether the operation is supported on each object. An error message could be seen if vendor SAI prints it.