[strict yang] Add YANG based cfg_schema.h to schema.h #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wen587
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @qiluo-msft and @xincunli-sonic , please help review this PR. This is a fixed version of #984 |
xincunli-sonic
previously approved these changes
Jun 26, 2025
qiluo-msft
reviewed
Jun 26, 2025
|
|
||
| #define CFG_HIGH_FREQUENCY_TELEMETRY_PROFILE_TABLE_NAME "HIGH_FREQUENCY_TELEMETRY_PROFILE" | ||
| #define CFG_HIGH_FREQUENCY_TELEMETRY_GROUP_TABLE_NAME "HIGH_FREQUENCY_TELEMETRY_GROUP" |
There was a problem hiding this comment.
I think the development experience of schema.h file will be changed after this PR. Could you share the design doc? and explain future development experience in design doc? #Closed
There was a problem hiding this comment.
Hi @qiluo-msft , please check here: sonic-net/SONiC#2026
The runtime enforcement will be added along the way.
qiluo-msft
reviewed
Jul 1, 2025
common/cfg_schema.h.pregenerated
Outdated
| #ifndef CFG_SCHEMA_H | ||
| #define CFG_SCHEMA_H | ||
|
|
||
| // Macros for table names are autogenerated by gen_cfg_schema.py. Manual update will not be preserved. |
There was a problem hiding this comment.
Currently no. Because there are CFG macros are needed for unit test in swss-common repo, such as logger.
It should be the CFG macro owner to ensure the file up to date.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To enable YANG based CFG table generation, the ConfigDB related macro will be generated by YANG model
How I did it
Add gen_cfg_schema.py script to generate cfg_schema.h which will be included in schema.h
Work item tracking
How to verify it
make deb build
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)